Skip to content

#637 - Expand DK local names - #640

Merged
bodiam merged 1 commit into
datafaker-net:mainfrom
robosoul:feature/637-expand-dk-local-names
Jan 19, 2023
Merged

bodiam merged 1 commit into
datafaker-net:mainfrom
robosoul:feature/637-expand-dk-local-names

Conversation

@robosoul

Copy link
Copy Markdown
Contributor

Expanded DK first/last name list.

Prior to change:

% grep 'last_name' src/main/resources/da-DK.yml | grep -o '[[][^]]*]' | sed 's/[[]//; s/[]]//; s/, /,/g' | tr ',' '\n' | wc -l            
      10

% grep 'first_name' src/main/resources/da-DK.yml | grep -o '[[][^]]*]' | sed 's/[[]//; s/[]]//; s/, /,/g' | tr ',' '\n' | wc -l 
      20

After the change:

% grep 'last_name' src/main/resources/da-DK.yml | grep -o '[[][^]]*]' | sed 's/[[]//; s/[]]//; s/, /,/g' | tr ',' '\n' | wc -l
     316
     
% grep '[^a-z]male_first_name' src/main/resources/da-DK.yml | grep -o '[[][^]]*]' | sed 's/[[]//; s/[]]//; s/, /,/g' | tr ',' '\n' | wc -l
     190

% grep 'female_first_name' src/main/resources/da-DK.yml | grep -o '[[][^]]*]' | sed 's/[[]//; s/[]]//; s/, /,/g' | tr ',' '\n' | wc -l
     115

@what-the-diff

what-the-diff Bot commented Jan 19, 2023

Copy link
Copy Markdown
  • Added female_first_name and male_first name to the yml file
  • Changed first name from a list of names to a combination of both lists, so that it can be either one or another

@robosoul robosoul mentioned this pull request Jan 19, 2023
@bodiam

bodiam commented Jan 19, 2023

Copy link
Copy Markdown
Contributor

Nice one, thanks!

@bodiam
bodiam merged commit cf311a2 into datafaker-net:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants