Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#644 - reusable merge of male/female names in the first_name collection #645

Conversation

robosoul
Copy link
Contributor

Ticket #644

@what-the-diff
Copy link

what-the-diff bot commented Jan 20, 2023

  • Added male_first_name and female_first name to en-PH.yml
  • Changed first name in fi-FI from a list of names to the combination of male and female lists
  • Removed duplication in nb-NO by splitting into two separate lists for males and females, then combining them with #{male/female} syntax

@codecov-commenter
Copy link

Codecov Report

Merging #645 (c18e1ca) into main (cd60d19) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #645   +/-   ##
=========================================
  Coverage     92.73%   92.73%           
- Complexity     2621     2622    +1     
=========================================
  Files           281      281           
  Lines          5396     5396           
  Branches        589      589           
=========================================
  Hits           5004     5004           
- Misses          240      241    +1     
+ Partials        152      151    -1     
Impacted Files Coverage Δ
.../main/java/net/datafaker/service/FakerContext.java 83.58% <0.00%> (-4.48%) ⬇️
.../java/net/datafaker/service/FakeValuesService.java 84.95% <0.00%> (+0.59%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bodiam
Copy link
Contributor

bodiam commented Jan 20, 2023

You're on a roll!

@bodiam bodiam merged commit 402b161 into datafaker-net:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants