Skip to content

Computer brands feature request #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

HattoriHenzo
Copy link
Contributor

Update the Computer faker with brands

@what-the-diff
Copy link

what-the-diff bot commented Jan 28, 2023

  • Added a new method to the Computer class called brand()
  • Updated the documentation of the Computer class with an additional sentence about brands
  • Added a list of computer brands in English (en) locale file under "computer" section
  • Tested that calling faker().computer().brand() returns not empty string value and does not throw any exception

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2023

Codecov Report

Merging #654 (32861bf) into main (a1e090e) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #654      +/-   ##
============================================
- Coverage     92.79%   92.73%   -0.06%     
  Complexity     2623     2623              
============================================
  Files           281      281              
  Lines          5396     5397       +1     
  Branches        589      589              
============================================
- Hits           5007     5005       -2     
- Misses          239      241       +2     
- Partials        150      151       +1     
Impacted Files Coverage Δ
...in/java/net/datafaker/providers/base/Computer.java 100.00% <100.00%> (ø)
.../main/java/net/datafaker/service/FakerContext.java 83.58% <0.00%> (-4.48%) ⬇️
...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java 92.59% <0.00%> (-3.71%) ⬇️
.../datafaker/transformations/sql/SqlTransformer.java 88.19% <0.00%> (+0.73%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bodiam
Copy link
Contributor

bodiam commented Jan 29, 2023

Looks great to me! Thank you! This is now available in the snapshot version.

@bodiam bodiam merged commit d57cc7c into datafaker-net:main Jan 29, 2023
@HattoriHenzo
Copy link
Contributor Author

Looks great to me! Thank you! This is now available in the snapshot version.

Thanks. I have some more fakers to add. Should I open an issue for each faker?

@panilya
Copy link
Collaborator

panilya commented Jan 29, 2023

No, you don't have to. Feel free to contribute without opening issue for each faker

This was referenced Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants