Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add computer brands #665

Merged
merged 1 commit into from
Feb 5, 2023
Merged

Conversation

kingthorin
Copy link
Collaborator

@kingthorin kingthorin commented Feb 4, 2023

Follow-up to: #654 & #652

Signed-off-by: kingthorin kingthorin@users.noreply.github.com

@what-the-diff
Copy link

what-the-diff bot commented Feb 4, 2023

  • Added Framework, Gateway and Gigabyte to the list of computer manufacturers.
  • Removed Sony from the list of computer manufacturers.

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2023

Codecov Report

Merging #665 (becd11f) into main (f9d0142) will decrease coverage by 0.02%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #665      +/-   ##
============================================
- Coverage     92.81%   92.79%   -0.02%     
  Complexity     2635     2635              
============================================
  Files           283      283              
  Lines          5429     5429              
  Branches        590      590              
============================================
- Hits           5039     5038       -1     
- Misses          241      242       +1     
  Partials        149      149              
Impacted Files Coverage Δ
.../main/java/net/datafaker/service/FakerContext.java 83.58% <0.00%> (-4.48%) ⬇️
...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java 96.29% <0.00%> (+3.70%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

- Framework is gaining momentum (https://frame.work/)
- Gateway is a long time brand (how could we forget/miss that cow
pattern logo 😉 https://gatewayusa.com/)
- Gigabyte not just motherboards and components, they do have laptops
and desktops https://www.gigabyte.com/

Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
@kingthorin
Copy link
Collaborator Author

Tweaked

@bodiam bodiam closed this Feb 5, 2023
@bodiam bodiam reopened this Feb 5, 2023
@bodiam
Copy link
Contributor

bodiam commented Feb 5, 2023

Also LGTM! Thanks!

@kingthorin kingthorin merged commit 34c43b8 into datafaker-net:main Feb 5, 2023
@kingthorin kingthorin deleted the comp-brands branch February 5, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants