Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static builder method for json transformer #669

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

snuyanzin
Copy link
Collaborator

Simplify invocation of json transformer builder in the same way like it is already done for sql transformer:
static builder method

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2023

Codecov Report

Merging #669 (2664499) into main (c4b6674) will increase coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #669      +/-   ##
============================================
+ Coverage     92.74%   92.76%   +0.01%     
- Complexity     2634     2635       +1     
============================================
  Files           283      283              
  Lines          5429     5430       +1     
  Branches        590      590              
============================================
+ Hits           5035     5037       +2     
+ Misses          244      243       -1     
  Partials        150      150              
Impacted Files Coverage Δ
.../java/net/datafaker/service/FakeValuesService.java 85.03% <100.00%> (ø)
...net/datafaker/transformations/JsonTransformer.java 95.61% <100.00%> (+0.03%) ⬆️
...n/java/net/datafaker/providers/base/BaseFaker.java 87.82% <0.00%> (-0.87%) ⬇️
.../datafaker/transformations/sql/SqlTransformer.java 88.19% <0.00%> (+0.73%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin snuyanzin merged commit ad482cf into datafaker-net:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants