More unit test improvements

[kingthorin]

• BaseFakerTest.java > Allow callers to optionally specify a regex to match against.
• UnitTest classes > Use newer unit test infrastructure where practical.

Signed-off-by: kingthorin kingthorin@users.noreply.github.com

[kingthorin]

I plan to continue through this, just wanted to submit it in case: 1) Anyone hated how I'd changed things. 2) You'd know it was being worked on 😉

This isn't a blocker for 1.8.0.

[codecov-commenter]

Codecov Report

Merging #682 (d2453f5) into main (4707012) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head d2453f5 differs from pull request most recent head 31caefc. Consider uploading reports for the commit 31caefc to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #682      +/-   ##
============================================
- Coverage     92.64%   92.61%   -0.04%     
+ Complexity     2624     2610      -14     
============================================
  Files           284      283       -1     
  Lines          5356     5319      -37     
  Branches        581      574       -7     
============================================
- Hits           4962     4926      -36     
  Misses          248      248              
+ Partials        146      145       -1     

Impacted Files	Coverage Δ
...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java	92.59% <0.00%> (-3.71%)	⬇️
src/main/java/net/datafaker/formats/Yaml.java
.../datafaker/transformations/sql/SqlTransformer.java	85.92% <0.00%> (+0.72%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[kingthorin]

No longer WIP, ready for review.

[snuyanzin]

I didn't get where regex is checked in new way?

[kingthorin]

I didn't get where regex is checked in new way?

Ugh, thanks. I lost it along the way in some step of the implementation/re-implementation. Fixed now.

[kingthorin]

@snuyanzin I think I've addressed both your concerns. I put the Pattern.compile inside the regex assertion, let me know if you think it should be in the of method. Checking regex string isEmpty seemed easiest. But, I guess I could try/catch on PatternSyntaxException or check empty pattern ^$ and set it null, then null check it prior to the assertion if that's preferable.

[kingthorin]

Fixed the build/test failure.