Skip to content

Make arg for generate Transformer Iterable rather than FakeSequence#683

Merged
snuyanzin merged 1 commit into
datafaker-net:mainfrom
snuyanzin:streams
Feb 10, 2023
Merged

Make arg for generate Transformer Iterable rather than FakeSequence#683
snuyanzin merged 1 commit into
datafaker-net:mainfrom
snuyanzin:streams

Conversation

@snuyanzin

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov-commenter

codecov-commenter commented Feb 10, 2023

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 9.09091% with 20 lines in your changes missing coverage. Please review.

Project coverage is 92.13%. Comparing base (6c464a0) to head (61aee44).
Report is 1076 commits behind head on main.

Files with missing lines Patch % Lines
.../datafaker/transformations/sql/SqlTransformer.java 10.00% 7 Missing and 2 partials ⚠️
...tafaker/transformations/JavaObjectTransformer.java 0.00% 8 Missing ⚠️
...net/datafaker/transformations/JsonTransformer.java 0.00% 0 Missing and 1 partial ⚠️
.../net/datafaker/transformations/XmlTransformer.java 0.00% 0 Missing and 1 partial ⚠️
...net/datafaker/transformations/YamlTransformer.java 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #683      +/-   ##
============================================
- Coverage     92.74%   92.13%   -0.62%     
+ Complexity     2646     2642       -4     
============================================
  Files           285      285              
  Lines          5447     5456       +9     
  Branches        590      595       +5     
============================================
- Hits           5052     5027      -25     
- Misses          243      272      +29     
- Partials        152      157       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kingthorin kingthorin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snuyanzin snuyanzin merged commit 2818ed9 into datafaker-net:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants