Skip to content

Make arg for generate Transformer Iterable rather than FakeSequence #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

snuyanzin
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Merging #683 (61aee44) into main (6c464a0) will decrease coverage by 0.62%.
The diff coverage is 9.09%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #683      +/-   ##
============================================
- Coverage     92.74%   92.13%   -0.62%     
+ Complexity     2646     2642       -4     
============================================
  Files           285      285              
  Lines          5447     5456       +9     
  Branches        590      595       +5     
============================================
- Hits           5052     5027      -25     
- Misses          243      272      +29     
- Partials        152      157       +5     
Impacted Files Coverage Δ
src/main/java/net/datafaker/formats/Format.java 75.00% <ø> (-8.34%) ⬇️
...tafaker/transformations/JavaObjectTransformer.java 37.50% <0.00%> (-6.95%) ⬇️
...net/datafaker/transformations/JsonTransformer.java 94.73% <0.00%> (-0.88%) ⬇️
...ava/net/datafaker/transformations/Transformer.java 100.00% <ø> (ø)
.../net/datafaker/transformations/XmlTransformer.java 92.13% <0.00%> (ø)
...net/datafaker/transformations/YamlTransformer.java 90.38% <0.00%> (ø)
.../datafaker/transformations/sql/SqlTransformer.java 85.92% <10.00%> (-1.54%) ⬇️
.../net/datafaker/transformations/CsvTransformer.java 100.00% <100.00%> (ø)
src/main/java/net/datafaker/formats/Csv.java 64.64% <0.00%> (-24.25%) ⬇️
...rc/main/java/net/datafaker/service/FakeValues.java 84.16% <0.00%> (+0.83%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snuyanzin snuyanzin merged commit 2818ed9 into datafaker-net:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants