Documentation 1.8/2.0 update. #688
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #688 +/- ##
============================================
+ Coverage 92.59% 92.61% +0.01%
- Complexity 2609 2610 +1
============================================
Files 283 283
Lines 5319 5319
Branches 574 574
============================================
+ Hits 4925 4926 +1
Misses 248 248
+ Partials 146 145 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -7,7 +7,7 @@ First and foremost thanks to anyone who contributes, very much appreciated. | |||
| - Submit a PR with your change and if there are no comments, changes will be merged in | |||
| - If you're not sure about the change, raise an issue and have a discussion before spending time coding it up | |||
| - Try and make one logical change per PR. That is not make many changes in one PR. Submit multiple PRs instead | |||
| - Java 8 is our target version. If you need anything older than that, we recommend using [Java Faker](https://github.com/DiUS/java-faker) instead. | |||
| - Since Datafaker 2.x, Java 17 is our target version. If you need anything older than that, we recommend using the 1.x versions of Datafaker instead. Note that while the 1.x is stable and free of known bugs, this branch won't receive future updates. | |||
There was a problem hiding this comment.
I might be over thinking here so don't block on it.
But because 2.x is up coming shouldn't this be "For" or "Starting with" instead of "Since"?
There was a problem hiding this comment.
You're probably right, I'm no native speaker. I'll update it, thanks!
| * Remove usage Format Json from BaseFaker by @RVRhub in https://github.com/datafaker-net/datafaker/pull/663 | ||
| * Include XML files in .gitattributes as text by @kingthorin in https://github.com/datafaker-net/datafaker/pull/664 | ||
| * Add computer brands by @kingthorin in https://github.com/datafaker-net/datafaker/pull/665 | ||
| * implement currently passing Xlint checks by @kingthorin in https://github.com/datafaker-net/datafaker/pull/667 |
There was a problem hiding this comment.
We should drop this line for now 😉
There was a problem hiding this comment.
well, wellllll... I just hope it will come back soonish!
|
DOH, seems I was late. |
No description provided.