Skip to content

Migrated Java 8 code to Java 17 syntax improvements. #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2023

Conversation

bodiam
Copy link
Contributor

@bodiam bodiam commented Feb 12, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #696 (1db4098) into main (a484889) will increase coverage by 0.00%.
The diff coverage is 91.22%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main     #696   +/-   ##
=========================================
  Coverage     92.40%   92.40%           
+ Complexity     2603     2602    -1     
=========================================
  Files           283      283           
  Lines          5318     5295   -23     
  Branches        573      568    -5     
=========================================
- Hits           4914     4893   -21     
- Misses          254      255    +1     
+ Partials        150      147    -3     
Impacted Files Coverage Δ
.../datafaker/transformations/sql/SqlTransformer.java 85.19% <60.00%> (ø)
...c/main/java/net/datafaker/providers/base/Code.java 97.70% <75.00%> (ø)
...ain/java/net/datafaker/providers/base/Barcode.java 90.47% <80.00%> (ø)
.../main/java/net/datafaker/idnumbers/NricNumber.java 95.65% <100.00%> (-0.78%) ⬇️
...main/java/net/datafaker/idnumbers/PeselNumber.java 100.00% <100.00%> (ø)
...java/net/datafaker/providers/base/DateAndTime.java 98.57% <100.00%> (ø)
...ain/java/net/datafaker/providers/base/Finance.java 98.52% <100.00%> (ø)
...ain/java/net/datafaker/providers/base/Hashing.java 85.71% <100.00%> (ø)
...in/java/net/datafaker/providers/base/Internet.java 91.66% <100.00%> (-0.11%) ⬇️
...in/java/net/datafaker/providers/base/Locality.java 64.81% <100.00%> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bodiam bodiam merged commit ad9f575 into main Feb 12, 2023
@bodiam bodiam deleted the migrate_code_to_java17_attempt_three branch February 12, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants