Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of methods with varargs and #{options.option ...} #7

Merged
merged 1 commit into from
Feb 6, 2022

Conversation

snuyanzin
Copy link
Collaborator

There 2 issues:

  1. Current code can not resolve the code with varargs e.g. Options.option
  2. Options does not have option method with String varargs which is implied by FakeValuesService

This PR adds check if there is varargs in method args and supports it, also adds Options.option with String varargs to make it working like

#{options.option '12','345','89','54321'}

the PR is same as DiUS/java-faker#703

@bodiam
Copy link
Contributor

bodiam commented Feb 6, 2022

Hi @snuyanzin , thanks again. It took me a bit longer to review this one, since I've added similar code recently, though I added it to Faker itself. I'll move my code also to Options.

@bodiam bodiam merged commit 494bcce into datafaker-net:master Feb 6, 2022
@snuyanzin snuyanzin deleted the options branch February 14, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants