Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

David Ogar #70

Merged
merged 6 commits into from
Mar 3, 2022
Merged

David Ogar #70

merged 6 commits into from
Mar 3, 2022

Conversation

The-True-Hooha
Copy link
Contributor

Added Nigeria to the list of providers

@@ -9,8 +9,7 @@
public class AustraliaTest extends AbstractFakerTest {

@Test
public void locations() {
assertThat(faker.australia().locations(), not(is(emptyOrNullString())));
public void locations() { assertThat(faker.australia().locations(), not(is(emptyOrNullString())));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misformatted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the corresponding format changes locally, please check my last commit to see if it's corrected.

Apologies.

src/main/java/net/datafaker/Nigeria.java Outdated Show resolved Hide resolved
@bodiam bodiam merged commit 6b0936c into datafaker-net:master Mar 3, 2022
@bodiam
Copy link
Contributor

bodiam commented Mar 3, 2022

@The-True-Hooha Thanks David, PR has been merged, most likely will be released over the weekend!!


protected Nigeria(Faker faker) {
this.faker = faker;
faker.fakeValuesService().addPath(Locale.ENGLISH, Paths.get("src/main/resources/en/nigeria.yml"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bodiam @The-True-Hooha I know this PR has already been merged, but this location is still wrong. I guess we need to come up with a test that actually prevents building a JAR whenever this shows up, because the test will succeed but the actual JAR will not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for letting me know, I even added an extra test to Faker It for this. No worries, I'll fix it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fixed, I removed this code, I already registered the yml file in the central spot.

Copy link
Contributor

@alesaudate alesaudate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See latest comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants