Conversation
| @Test | ||
| public void locations() { | ||
| assertThat(faker.australia().locations(), not(is(emptyOrNullString()))); | ||
| public void locations() { assertThat(faker.australia().locations(), not(is(emptyOrNullString()))); |
There was a problem hiding this comment.
I made the corresponding format changes locally, please check my last commit to see if it's corrected.
Apologies.
|
@The-True-Hooha Thanks David, PR has been merged, most likely will be released over the weekend!! |
|
|
||
| protected Nigeria(Faker faker) { | ||
| this.faker = faker; | ||
| faker.fakeValuesService().addPath(Locale.ENGLISH, Paths.get("src/main/resources/en/nigeria.yml")); |
There was a problem hiding this comment.
@bodiam @The-True-Hooha I know this PR has already been merged, but this location is still wrong. I guess we need to come up with a test that actually prevents building a JAR whenever this shows up, because the test will succeed but the actual JAR will not.
There was a problem hiding this comment.
Ah, thanks for letting me know, I even added an extra test to Faker It for this. No worries, I'll fix it.
There was a problem hiding this comment.
It's fixed, I removed this code, I already registered the yml file in the central spot.
3 participants
Added Nigeria to the list of providers