Skip to content

Reformat and Enrich device.yml #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2023
Merged

Conversation

yuokada
Copy link
Contributor

@yuokada yuokada commented Feb 16, 2023

Overview

  • Reformat device.yml
  • Add new devices and manufactures to device.yml

@codecov-commenter
Copy link

Codecov Report

Merging #715 (e7611a7) into main (f1c937f) will increase coverage by 0.11%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #715      +/-   ##
============================================
+ Coverage     92.81%   92.93%   +0.11%     
- Complexity     2577     2579       +2     
============================================
  Files           281      281              
  Lines          5108     5108              
  Branches        529      529              
============================================
+ Hits           4741     4747       +6     
+ Misses          235      231       -4     
+ Partials        132      130       -2     
Impacted Files Coverage Δ
.../java/net/datafaker/service/FakeValuesService.java 84.28% <0.00%> (-0.20%) ⬇️
.../main/java/net/datafaker/service/FakerContext.java 88.05% <0.00%> (+4.47%) ⬆️
.../main/java/net/datafaker/providers/base/Lorem.java 100.00% <0.00%> (+6.25%) ⬆️
...ain/java/net/datafaker/idnumbers/KoKrIdNumber.java 87.50% <0.00%> (+6.25%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bodiam
Copy link
Contributor

bodiam commented Feb 16, 2023

Thanks, looks good to me!

@bodiam bodiam merged commit 70ca376 into datafaker-net:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants