Skip to content

Add allergens in Food provider - #724

Merged
kingthorin merged 1 commit into
datafaker-net:mainfrom
panilya:add-allergents
Feb 28, 2023
Merged

Add allergens in Food provider#724
kingthorin merged 1 commit into
datafaker-net:mainfrom
panilya:add-allergents

Conversation

@panilya

@panilya panilya commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

@what-the-diff

what-the-diff Bot commented Feb 28, 2023

Copy link
Copy Markdown
  • Added a new method to the Food class called allergen()
  • Updated food.yml with allergens data
  • Tested that the newly added method works as expected by adding it to providerListTest().

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #724 (a6f8f43) into main (2fb8051) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #724      +/-   ##
============================================
- Coverage     92.91%   92.89%   -0.02%     
- Complexity     2580     2581       +1     
============================================
  Files           281      281              
  Lines          5109     5110       +1     
  Branches        528      528              
============================================
  Hits           4747     4747              
- Misses          234      235       +1     
  Partials        128      128              
Impacted Files Coverage Δ
...c/main/java/net/datafaker/providers/food/Food.java 100.00% <100.00%> (ø)
.../java/net/datafaker/service/FakeValuesService.java 84.50% <0.00%> (-0.40%) ⬇️
...ain/java/net/datafaker/idnumbers/KoKrIdNumber.java 87.50% <0.00%> (+6.25%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread src/test/java/net/datafaker/providers/foods/FoodTest.java
@snuyanzin

Copy link
Copy Markdown
Collaborator

in general lgtm
there is a nit comment

@kingthorin kingthorin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kingthorin
kingthorin merged commit 5fc1fbc into datafaker-net:main Feb 28, 2023
@panilya
panilya deleted the add-allergents branch February 28, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants