Skip to content

Fix Kotlin examples in Transformers documentation - #725

Merged
bodiam merged 1 commit into
datafaker-net:mainfrom
panilya:fix-kotlin-transformers-docs
Feb 28, 2023
Merged

Fix Kotlin examples in Transformers documentation#725
bodiam merged 1 commit into
datafaker-net:mainfrom
panilya:fix-kotlin-transformers-docs

Conversation

@panilya

@panilya panilya commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator

Issue: #711

@what-the-diff

what-the-diff Bot commented Feb 28, 2023

Copy link
Copy Markdown
  • Add faker instance to schema example
  • Fix CsvTransformerBuilder type parameter declaration
  • Remove unnecessary <String> from JsonTransformer builder call
  • Update SqlTransformaer build examples with correct class name and remove redundant in the first one
  • Change Schema#of method invocation to static factory method call (Schema::of)

@panilya
panilya requested a review from bodiam February 28, 2023 14:13
kingthorin
kingthorin reviewed Feb 28, 2023
View reviewed changes
Comment thread docs/documentation/schemas.md
@bodiam
bodiam merged commit 6397117 into datafaker-net:main Feb 28, 2023
@panilya panilya mentioned this pull request Mar 6, 2023
Closed
bodiam pushed a commit that referenced this pull request Mar 15, 2023
@panilya @bodiam
Fix Kotlin examples in Transformers documentation (#725)
42ebf2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kingthorin kingthorin kingthorin approved these changes
@bodiam bodiam Awaiting requested review from bodiam

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@panilya @kingthorin @bodiam