-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring - Implementation refactoring #739
Conversation
PR Summary
|
Strange PR. Is this a test of an AI refactoring or so? |
Co-authored-by: Sergey Nuyanzin <sergey.nuyanzin@aiven.io>
…into Refactoring
No, I am working on an assignment, which is on refactoring and encourages us to contribute to open source repositories. |
Co-authored-by: Sergey Nuyanzin <sergey.nuyanzin@aiven.io>
Ah, that explains! I was surprised by the overly structured changeset, normally it's something like "changed a thing", and not used to such extended descriptions. Thank you for picking this project for your assignment. Happy to integrate your contributions into this project! |
(Though it seems the build is failing) |
I will check on that and open a fresh PR. Any suggestions on how I should proceed? |
Refactor1 : Worked on the failed build for previous PR #739
This PR has three different implementation refactoring performed.