Refactor1 : Worked on the failed build for previous PR #739#744
Refactor1 : Worked on the failed build for previous PR #739#744kingthorin merged 7 commits intodatafaker-net:mainfrom
Conversation
PR Summary
|
this does not look like true. Stack trace (Click the triangle/control to the left to expand |
|
The failure must be related to your Number.java changes. |
|
@snuyanzin is the JavaDoc in Number.java wrong? * @param min the lower bound (include min)
* @param max the lower bound (not include max)Shouldn't max be "upper"? |
yes, 3 times |
Yes, thank you for pointing it out, fixed. |
yes! did not notice it at first, made the changes in java doc. |
fixed. |
|
Thanks |
almasfiza
requested review from
kingthorin and
snuyanzin
and removed request for
snuyanzin
|
They haven't posted an outage yet but it seems like something is up with GitHub ations. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #744 +/- ##
============================================
- Coverage 92.84% 92.82% -0.02%
- Complexity 2592 2595 +3
============================================
Files 281 281
Lines 5126 5130 +4
Branches 530 530
============================================
+ Hits 4759 4762 +3
- Misses 240 241 +1
Partials 127 127
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
|
I think you need to pickup these changes: #745 Assuming git fetch upstream
git rebase upstream/main
git push --force-with-lease |
|
I get this error. |
|
Looks like you have origin set to this repo instead of yours. |
|
Or maybe you aren't tracking the right repo. Try |
Yes, i tried changing the origin to my repo, but now when i try fetch, it does not return anything.
Tried the push -u origin refactor1 --force-with-lease too |
|
Okay, when you fetch now there's nothing to fetch because you've done it and things are up-to-date. Have you made local changes that haven't been pushed? What does |
I have not made any changes. git status shows On branch refactor1 nothing to commit, working tree clean I was trying to fetch the changes from #745. |
|
Okay, try this then. git fetch origin
# Shouldn't really do anything but maybe it'll sort out the stale situation
git fetch upstream
# Shouldn't really do anything because there hasn't been any changes in the last hour or so, but may as well ensure up-to-date
git rebase upstream/main
git push -u origin refactor1 --force |
They were pretty minor, I'd suggest just re-implementing them after you get this sorted out. |
|
Yay, looks like it worked out that time 🎉 |
Yes, it works! Hoping it passes all the checks. Thank you very much for your help and patience! :') Still figuring open source out. |
|
No problem, there's a learning curve, been there 😉 all good. |
|
thanks for your contribution lgtm, once ci is passed |
Thank you, The checks are still queued - waiting to run this check. |
All checks have passed. |
4 participants
The build was failing because of using the same function name for int and long generating functions. I have only added the code for int function - decomposed the conditional in refactoring, all the rest of the changes are as same as previous PR. (#739)