Skip to content

Feature/hacker localization nb no #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Majid-J
Copy link
Contributor

@Majid-J Majid-J commented Apr 3, 2023

Added Norwegian localization for Hacker (adjectives, nouns and verbs).

@kingthorin
Copy link
Collaborator

Do you care that your commits are from two different accounts?

@codecov-commenter
Copy link

Codecov Report

Merging #755 (96aeeb3) into main (b6dcc89) will increase coverage by 0.05%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #755      +/-   ##
============================================
+ Coverage     92.80%   92.86%   +0.05%     
  Complexity     2595     2595              
============================================
  Files           281      281              
  Lines          5127     5127              
  Branches        530      530              
============================================
+ Hits           4758     4761       +3     
+ Misses          243      240       -3     
  Partials        126      126              

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Majid-J
Copy link
Contributor Author

Majid-J commented Apr 3, 2023

Do you care that your commits are from two different accounts?

No, I don't mind :)

Copy link
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no familiarity with the localized languages, but format wise these seem fine to me.

@bodiam
Copy link
Contributor

bodiam commented Apr 3, 2023

Looks fine to me! Thanks for your contribution!

@bodiam bodiam merged commit 6c64790 into datafaker-net:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants