Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aviation provider: Added more aircraft. #761

Merged

Conversation

L-Evg
Copy link
Contributor

@L-Evg L-Evg commented Apr 12, 2023

Added more items under aircraft (both planes and copters) sections.

@codecov-commenter
Copy link

Codecov Report

Merging #761 (0001ab1) into main (55e3a7c) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #761      +/-   ##
============================================
- Coverage     92.86%   92.82%   -0.04%     
  Complexity     2595     2595              
============================================
  Files           281      281              
  Lines          5127     5130       +3     
  Branches        530      530              
============================================
+ Hits           4761     4762       +1     
- Misses          240      242       +2     
  Partials        126      126              
Impacted Files Coverage Δ
...in/java/net/datafaker/providers/base/Aviation.java 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kingthorin kingthorin merged commit 7d0cb9d into datafaker-net:main Apr 12, 2023
@bodiam
Copy link
Contributor

bodiam commented Apr 12, 2023

Thanks all for PR and merging! That went fast!

army_helicopter: [AH-1Z Viper, V-22 Osprey, MD 500 Defender, AH64 Apache, UH-72 Lakota, HH-60 Pave Hawk, UH-60 Black Hawk, Bell 206, CH-53 Sea Stallion, CH-47 Chinook, CH-46 Sea Knight, OH-6 Cayuse]
civil_helicopter: [Airbus H125, Airbus H130, Airbus H135, Airbus H145, Airbus H155, Airbus H160, Airbus H175, Airbus H215, Airbus H225, Robinson R66 Turbine, Robinson R44 Raven II, Robinson R44 Raven I, Robinson R44 Cadet, Robinson R22 Beta II, Sikorsky S-76, Sikorsky S-92]
army_helicopter: [A.109K HIRUNDO, А.129 MANGUSTA, А.139 LBH, AH-1Z Viper, AS.565 PANTHER, AS.332 Super Puma Mk.2, AS.532A2 Cougar Mk.2, НAC TIGRE, НAP GERFAUT, SA.342 GAZELLE, SA.365M DAUPHIN II, Вo.105, V-22 Osprey, MD 500 Defender, AH64 Apache, WAH-64D APACHE AH.1, АН-1W, LYNX АН Mk.1, LYNX АН Mk.7, LYNX АН Mk.9, UH-72 Lakota, HH-60 Pave Hawk, UH-60 Black Hawk, Bell 206, CH-53 Sea Stallion, CH-47 Chinook, CH-46 Sea Knight, OH-6 Cayuse, Mi-8AMTSh, Mi-24, Mi-28, Mi-35, PAH-2 TIGER, RAN-66 COMANCHE, Ka-27, Ka-50, Ka-52, WZ-9, Z-11WB]
civil_helicopter: [Airbus H125, Airbus H130, Airbus H135, Airbus H145, Airbus H155, Airbus H160, Airbus H175, Airbus H215, Airbus H225, AgustaWestland AW.159, AgustaWestland AW.169, AgustaWestland AW.189, Mil Mi-2, Mil Mi-8, Mil Mi-26, Mil Mi-171, Mil Mi-38, Robinson R66 Turbine, Robinson R44 Raven II, Robinson R44 Raven I, Robinson R44 Cadet, Robinson R22 Beta II, Sikorsky S-76, Sikorsky S-92, Kamov Ka-26, Kamov Ka-226, ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a redundant comma at the end. Please, remove that comma and extra spaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants