Red Dead Redemption 2 Provider #766
Conversation
|
Could you remove the unrelated commits please |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #766 +/- ##
=========================================
Coverage 92.78% 92.78%
- Complexity 2594 2615 +21
=========================================
Files 281 283 +2
Lines 5130 5173 +43
Branches 530 533 +3
=========================================
+ Hits 4760 4800 +40
- Misses 243 245 +2
- Partials 127 128 +1
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
src/main/java/net/datafaker/providers/videogame/RedDeadRedemption2.java
Outdated
Show resolved
Hide resolved
Majid-J
force-pushed
the
feature/red-dead-redemption-2-provider
branch
from
13351ee to
4db27e7
Compare
| import net.datafaker.providers.base.AbstractProvider; | ||
|
|
||
| /** | ||
| * Red Dead Redemption 2 is an action-adventure game developed and published by Rockstar Games. |
There was a problem hiding this comment.
Thanks for adding this documentation here!!
|
Thanks for this great PR! Looks good to me too! |
| TestSpec.of(redDeadRedemption2::protagonist, "red_dead_redemption2.protagonists"), | ||
| TestSpec.of(redDeadRedemption2::gangMember, "red_dead_redemption2.gang_members"), | ||
| TestSpec.of(redDeadRedemption2::majorCharacter, "red_dead_redemption2.major_characters"), | ||
| TestSpec.of(redDeadRedemption2::animal, "red_dead_redemption2.animals"), | ||
| TestSpec.of(redDeadRedemption2::state, "red_dead_redemption2.states"), | ||
| TestSpec.of(redDeadRedemption2::region, "red_dead_redemption2.regions"), | ||
| TestSpec.of(redDeadRedemption2::settlement, "red_dead_redemption2.settlements"), | ||
| TestSpec.of(redDeadRedemption2::quote, "red_dead_redemption2.quotes"), | ||
| TestSpec.of(redDeadRedemption2::weapon, "red_dead_redemption2.weapons") |
There was a problem hiding this comment.
would be better if it satisfies abc order
| TestSpec.of(redDeadRedemption2::protagonist, "red_dead_redemption2.protagonists"), | ||
| TestSpec.of(redDeadRedemption2::gangMember, "red_dead_redemption2.gang_members"), | ||
| TestSpec.of(redDeadRedemption2::majorCharacter, "red_dead_redemption2.major_characters"), | ||
| TestSpec.of(redDeadRedemption2::animal, "red_dead_redemption2.animals"), | ||
| TestSpec.of(redDeadRedemption2::state, "red_dead_redemption2.states"), | ||
| TestSpec.of(redDeadRedemption2::region, "red_dead_redemption2.regions"), | ||
| TestSpec.of(redDeadRedemption2::settlement, "red_dead_redemption2.settlements"), | ||
| TestSpec.of(redDeadRedemption2::quote, "red_dead_redemption2.quotes"), | ||
| TestSpec.of(redDeadRedemption2::weapon, "red_dead_redemption2.weapons") |
There was a problem hiding this comment.
would be better if it satisfies abc order
There was a problem hiding this comment.
(And sorry, I missed your comment just when I was merging it!)
There was a problem hiding this comment.
probably that was the reason github has rejected with submission of my first comment...
ok,,
Added a provider for Red Dead Redemption 2.