Red Dead Redemption 2 Provider - #766
Merged
bodiam merged 2 commits intoApr 14, 2023
Merged
Conversation
Collaborator
|
Could you remove the unrelated commits please |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #766 +/- ##
=========================================
Coverage 92.78% 92.78%
- Complexity 2594 2615 +21
=========================================
Files 281 283 +2
Lines 5130 5173 +43
Branches 530 533 +3
=========================================
+ Hits 4760 4800 +40
- Misses 243 245 +2
- Partials 127 128 +1
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kingthorin
reviewed
Apr 14, 2023
Majid-J
force-pushed
the
feature/red-dead-redemption-2-provider
branch
from
April 14, 2023 13:21
13351ee to
4db27e7
Compare
bodiam
reviewed
Apr 14, 2023
| import net.datafaker.providers.base.AbstractProvider; | ||
|
|
||
| /** | ||
| * Red Dead Redemption 2 is an action-adventure game developed and published by Rockstar Games. |
Contributor
There was a problem hiding this comment.
Thanks for adding this documentation here!!
Contributor
|
Thanks for this great PR! Looks good to me too! |
snuyanzin
reviewed
Apr 14, 2023
Comment on lines
+13
to
+21
| TestSpec.of(redDeadRedemption2::protagonist, "red_dead_redemption2.protagonists"), | ||
| TestSpec.of(redDeadRedemption2::gangMember, "red_dead_redemption2.gang_members"), | ||
| TestSpec.of(redDeadRedemption2::majorCharacter, "red_dead_redemption2.major_characters"), | ||
| TestSpec.of(redDeadRedemption2::animal, "red_dead_redemption2.animals"), | ||
| TestSpec.of(redDeadRedemption2::state, "red_dead_redemption2.states"), | ||
| TestSpec.of(redDeadRedemption2::region, "red_dead_redemption2.regions"), | ||
| TestSpec.of(redDeadRedemption2::settlement, "red_dead_redemption2.settlements"), | ||
| TestSpec.of(redDeadRedemption2::quote, "red_dead_redemption2.quotes"), | ||
| TestSpec.of(redDeadRedemption2::weapon, "red_dead_redemption2.weapons") |
Collaborator
There was a problem hiding this comment.
would be better if it satisfies abc order
Comment on lines
+13
to
+21
| TestSpec.of(redDeadRedemption2::protagonist, "red_dead_redemption2.protagonists"), | ||
| TestSpec.of(redDeadRedemption2::gangMember, "red_dead_redemption2.gang_members"), | ||
| TestSpec.of(redDeadRedemption2::majorCharacter, "red_dead_redemption2.major_characters"), | ||
| TestSpec.of(redDeadRedemption2::animal, "red_dead_redemption2.animals"), | ||
| TestSpec.of(redDeadRedemption2::state, "red_dead_redemption2.states"), | ||
| TestSpec.of(redDeadRedemption2::region, "red_dead_redemption2.regions"), | ||
| TestSpec.of(redDeadRedemption2::settlement, "red_dead_redemption2.settlements"), | ||
| TestSpec.of(redDeadRedemption2::quote, "red_dead_redemption2.quotes"), | ||
| TestSpec.of(redDeadRedemption2::weapon, "red_dead_redemption2.weapons") |
Collaborator
There was a problem hiding this comment.
would be better if it satisfies abc order
Contributor
There was a problem hiding this comment.
(And sorry, I missed your comment just when I was merging it!)
Collaborator
There was a problem hiding this comment.
probably that was the reason github has rejected with submission of my first comment...
ok,,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a provider for Red Dead Redemption 2.