Skip to content

BaseFakerTest - Assert that provider lists should not have blank entries - #769

Merged
bodiam merged 1 commit into
datafaker-net:mainfrom
kingthorin:prov-base-test
Apr 16, 2023
Merged

BaseFakerTest - Assert that provider lists should not have blank entries#769
bodiam merged 1 commit into
datafaker-net:mainfrom
kingthorin:prov-base-test

Conversation

@kingthorin

Copy link
Copy Markdown
Collaborator

As discussed in: #762

Tested with entries such as:
"" (empty)
" " (space)
" " (tab)
"\n" (new line literal)

Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #769 (98c3282) into main (2446610) will decrease coverage by 0.04%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #769      +/-   ##
============================================
- Coverage     92.82%   92.78%   -0.04%     
+ Complexity     2616     2615       -1     
============================================
  Files           283      283              
  Lines          5173     5173              
  Branches        533      533              
============================================
- Hits           4802     4800       -2     
- Misses          244      245       +1     
- Partials        127      128       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bodiam

bodiam commented Apr 16, 2023

Copy link
Copy Markdown
Contributor

Nice, looks good!

@bodiam
bodiam merged commit f74ce56 into datafaker-net:main Apr 16, 2023
@kingthorin
kingthorin deleted the prov-base-test branch April 16, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants