Skip to content

Remove unused package private method and tests#772

Merged
kingthorin merged 1 commit into
datafaker-net:mainfrom
snuyanzin:diasese
Apr 16, 2023
Merged

Remove unused package private method and tests#772
kingthorin merged 1 commit into
datafaker-net:mainfrom
snuyanzin:diasese

Conversation

@snuyanzin

Copy link
Copy Markdown
Collaborator

Since now tests able to read data from file to construct expected set we don't need to call tests thousand number of times

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #772 (ef39f47) into main (8cbb8b9) will decrease coverage by 0.06%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #772      +/-   ##
============================================
- Coverage     92.86%   92.81%   -0.06%     
+ Complexity     2633     2632       -1     
============================================
  Files           284      284              
  Lines          5202     5202              
  Branches        537      537              
============================================
- Hits           4831     4828       -3     
- Misses          243      245       +2     
- Partials        128      129       +1     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kingthorin kingthorin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kingthorin kingthorin merged commit 5fc6904 into datafaker-net:main Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants