Skip to content

Aviation provider: Airport names and more ICAO airport codes. #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

L-Evg
Copy link
Contributor

@L-Evg L-Evg commented Apr 17, 2023

  • Added "airport_name" field.
  • Added more ICAO airport codes.

Copy link
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have source info for these PRs.

  1. For future updates.
  2. Because we have no way to validate accuracy.

@snuyanzin
Copy link
Collaborator

It would be good to have source info for these PRs.

i wonder whether we should add this notice to PULL_REQUEST_TEMPLATE

@L-Evg
Copy link
Contributor Author

L-Evg commented Apr 17, 2023

@kingthorin - I took the list from http://www.flugzeuginfo.net/table_airportcodes_country-location_en.php . If you like I could add that info this PR or the next one.

@kingthorin
Copy link
Collaborator

kingthorin commented Apr 17, 2023

@snuyanzin thats a great idea, I’ll set something up.

@L-Evg thank you!

@L-Evg L-Evg requested a review from kingthorin April 17, 2023 11:17
@codecov-commenter
Copy link

Codecov Report

Merging #774 (4f7d2cd) into main (5fc6904) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #774      +/-   ##
============================================
- Coverage     92.82%   92.79%   -0.04%     
+ Complexity     2633     2632       -1     
============================================
  Files           284      284              
  Lines          5202     5203       +1     
  Branches        537      537              
============================================
- Hits           4829     4828       -1     
  Misses          245      245              
- Partials        128      130       +2     
Impacted Files Coverage Δ
...in/java/net/datafaker/providers/base/Aviation.java 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bodiam
Copy link
Contributor

bodiam commented Apr 17, 2023

That's a lot of data! I don't mind it, but just curious : are you building something related to airlines or so?

@L-Evg
Copy link
Contributor Author

L-Evg commented Apr 18, 2023

@bodiam - nothing real actually, I am just extending an educational application related to aviation (a flight ticket booking app). But the further it goes the more features I would like to add there.

@bodiam bodiam merged commit 03a76c8 into datafaker-net:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants