Skip to content

Aviation provider: Airport names and more ICAO airport codes. - #774

Merged
bodiam merged 2 commits into
datafaker-net:mainfrom
L-Evg:feature/Aviation_provider_airport_names
Apr 18, 2023
Merged

Aviation provider: Airport names and more ICAO airport codes.#774
bodiam merged 2 commits into
datafaker-net:mainfrom
L-Evg:feature/Aviation_provider_airport_names

Conversation

@L-Evg

@L-Evg L-Evg commented Apr 17, 2023

Copy link
Copy Markdown
Contributor
  • Added "airport_name" field.
  • Added more ICAO airport codes.

@kingthorin kingthorin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have source info for these PRs.

  1. For future updates.
  2. Because we have no way to validate accuracy.

@snuyanzin

Copy link
Copy Markdown
Collaborator

It would be good to have source info for these PRs.

i wonder whether we should add this notice to PULL_REQUEST_TEMPLATE

@L-Evg

L-Evg commented Apr 17, 2023

Copy link
Copy Markdown
Contributor Author

@kingthorin - I took the list from http://www.flugzeuginfo.net/table_airportcodes_country-location_en.php . If you like I could add that info this PR or the next one.

@kingthorin

kingthorin commented Apr 17, 2023

Copy link
Copy Markdown
Collaborator

@snuyanzin thats a great idea, I’ll set something up.

@L-Evg thank you!

@L-Evg
L-Evg requested a review from kingthorin April 17, 2023 11:17
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #774 (4f7d2cd) into main (5fc6904) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #774      +/-   ##
============================================
- Coverage     92.82%   92.79%   -0.04%     
+ Complexity     2633     2632       -1     
============================================
  Files           284      284              
  Lines          5202     5203       +1     
  Branches        537      537              
============================================
- Hits           4829     4828       -1     
  Misses          245      245              
- Partials        128      130       +2     
Impacted Files Coverage Δ
...in/java/net/datafaker/providers/base/Aviation.java 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bodiam

bodiam commented Apr 17, 2023

Copy link
Copy Markdown
Contributor

That's a lot of data! I don't mind it, but just curious : are you building something related to airlines or so?

@L-Evg

L-Evg commented Apr 18, 2023

Copy link
Copy Markdown
Contributor Author

@bodiam - nothing real actually, I am just extending an educational application related to aviation (a flight ticket booking app). But the further it goes the more features I would like to add there.

@bodiam
bodiam merged commit 03a76c8 into datafaker-net:main Apr 18, 2023
@L-Evg
L-Evg deleted the feature/Aviation_provider_airport_names branch April 15, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants