Aviation provider: Airport names and more ICAO airport codes. - #774
Conversation
L-Evg
commented
Apr 17, 2023
- Added "airport_name" field.
- Added more ICAO airport codes.
kingthorin
left a comment
There was a problem hiding this comment.
It would be good to have source info for these PRs.
- For future updates.
- Because we have no way to validate accuracy.
i wonder whether we should add this notice to PULL_REQUEST_TEMPLATE |
|
@kingthorin - I took the list from http://www.flugzeuginfo.net/table_airportcodes_country-location_en.php . If you like I could add that info this PR or the next one. |
|
@snuyanzin thats a great idea, I’ll set something up. @L-Evg thank you! |
…a reference to the airports list source.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #774 +/- ##
============================================
- Coverage 92.82% 92.79% -0.04%
+ Complexity 2633 2632 -1
============================================
Files 284 284
Lines 5202 5203 +1
Branches 537 537
============================================
- Hits 4829 4828 -1
Misses 245 245
- Partials 128 130 +2
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
That's a lot of data! I don't mind it, but just curious : are you building something related to airlines or so? |
|
@bodiam - nothing real actually, I am just extending an educational application related to aviation (a flight ticket booking app). But the further it goes the more features I would like to add there. |