Merged
Conversation
PR Summary
|
kingthorin
reviewed
Apr 21, 2023
| @@ -0,0 +1,37 @@ | |||
| package net.datafaker.providers.videogame; | |||
Collaborator
There was a problem hiding this comment.
Should we move other video games in here?
Should this be a sub-package within entertainment?
Contributor
There was a problem hiding this comment.
Whatever we do, it will never be right. Lord of the Rings. Is that a book, movies, a game, tv series?
But I am not really bothered with how it's organized. If there's some consistency, that's nice, and if you want to move don't packages around, I won't stop you :)
Collaborator
There was a problem hiding this comment.
Alright, that's fair.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.