Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Final Fantasy XIV faker #783

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Conversation

panilya
Copy link
Collaborator

@panilya panilya commented Apr 21, 2023

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Apr 21, 2023

PR Summary

  • Added FinalFantasyXIV Class
    A new class has been added to the VideoGameProviders interface, supporting the Final Fantasy XIV game.
  • Added final_fantasy_xiv.yml File
    This file contains data for the newly implemented provider.
  • Created Test Case for New Provider
    A test case has been created to ensure all methods of the new provider function as intended.

@@ -0,0 +1,37 @@
package net.datafaker.providers.videogame;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move other video games in here?
Should this be a sub-package within entertainment?

@bodiam

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever we do, it will never be right. Lord of the Rings. Is that a book, movies, a game, tv series?

But I am not really bothered with how it's organized. If there's some consistency, that's nice, and if you want to move don't packages around, I won't stop you :)

Copy link
Collaborator

@kingthorin kingthorin Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, that's fair.

@bodiam bodiam merged commit 3d4c572 into datafaker-net:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants