Skip to content

Add degree in University faker#785

Merged
bodiam merged 1 commit intodatafaker-net:mainfrom
panilya:add-uni-degree
Apr 23, 2023
Merged

Add degree in University faker#785
bodiam merged 1 commit intodatafaker-net:mainfrom
panilya:add-uni-degree

Conversation

@panilya
Copy link
Copy Markdown
Collaborator

@panilya panilya commented Apr 23, 2023

No description provided.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Apr 23, 2023

## PR Summary

* **Added degree() method to University class**
A new method called 'degree()' has been added to the University class, providing additional functionality.

* **Updated university.yml for new method**
The university.yml file has been updated with an array of degree options, which can be returned by the newly added 'degree()' method.

* **Added test coverage for new method**
Test cases have been updated, including the addition of a TestSpec object specifically for the 'degree()' method to ensure that the code has full test coverage and that future changes won't break existing functionality or tests.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 23, 2023

Codecov Report

Merging #785 (a7b9153) into main (3d4c572) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #785      +/-   ##
============================================
- Coverage     92.89%   92.84%   -0.06%     
- Complexity     2641     2642       +1     
============================================
  Files           285      285              
  Lines          5211     5212       +1     
  Branches        537      537              
============================================
- Hits           4841     4839       -2     
- Misses          242      245       +3     
  Partials        128      128              
Impacted Files Coverage Δ
.../java/net/datafaker/providers/base/University.java 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bodiam bodiam merged commit dc4cfcf into datafaker-net:main Apr 23, 2023
@bodiam
Copy link
Copy Markdown
Contributor

bodiam commented Apr 23, 2023

Nice one!

@panilya panilya deleted the add-uni-degree branch April 23, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants