Skip to content

Different types of transport fake data #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2023
Merged

Different types of transport fake data #791

merged 2 commits into from
Apr 29, 2023

Conversation

sergejsvisockis
Copy link
Contributor

The following merge request contains new fake transport-related data.

@what-the-diff
Copy link

what-the-diff bot commented Apr 29, 2023

PR Summary

  • Added new provider for transport type
    A new provider has been introduced to extend the range of transport types.
  • Updated list of possible values for the new provider
    The list of possible values for this provider has been added to an existing file to keep everything organized.
  • Created test class and integrated into BaseFakerTest
    A new test class has been created to ensure all works fine with the new provider and has been integrated into the BaseFakerTest to avoid code duplication.

@sergejsvisockis sergejsvisockis changed the title The transport fakers The transport fake data Apr 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2023

Codecov Report

Merging #791 (64f4992) into main (a337f6a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #791      +/-   ##
============================================
- Coverage     92.92%   92.90%   -0.02%     
- Complexity     2644     2646       +2     
============================================
  Files           284      285       +1     
  Lines          5212     5216       +4     
  Branches        537      537              
============================================
+ Hits           4843     4846       +3     
  Misses          241      241              
- Partials        128      129       +1     
Impacted Files Coverage Δ
.../main/java/net/datafaker/service/files/EnFile.java 93.33% <ø> (ø)
...va/net/datafaker/providers/base/BaseProviders.java 100.00% <100.00%> (ø)
...n/java/net/datafaker/providers/base/Transport.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergejsvisockis sergejsvisockis changed the title The transport fake data Different types of transport fake data Apr 29, 2023
@kingthorin kingthorin merged commit 280729c into datafaker-net:main Apr 29, 2023
@kingthorin
Copy link
Collaborator

kingthorin commented Apr 29, 2023

Thanks

@sergejsvisockis
Copy link
Contributor Author

Thanks

You are always welcome :)

@sergejsvisockis sergejsvisockis deleted the transport_faker branch April 30, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants