Introduce cache of suppliers and remove usage of Objects.hash to speed up#792
Merged
Conversation
PR Summary
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #792 +/- ##
============================================
- Coverage 92.92% 92.54% -0.38%
- Complexity 2647 2654 +7
============================================
Files 285 286 +1
Lines 5216 5274 +58
Branches 537 553 +16
============================================
+ Hits 4847 4881 +34
- Misses 241 252 +11
- Partials 128 141 +13
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kingthorin
reviewed
Apr 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem with
Objects.hashis that it generates an array each time it is called.Suppliers could be cached to avoid parsing of expressions each time
it gives speed up for a wide range of methods up to 50 %
expressions
csv generation
kotlin faker benchmark
simple methods calls