Skip to content

Replace deprecated class#newInstance - #796

Merged
snuyanzin merged 1 commit into
datafaker-net:mainfrom
snuyanzin:newinstance
Apr 30, 2023
Merged

Replace deprecated class#newInstance#796
snuyanzin merged 1 commit into
datafaker-net:mainfrom
snuyanzin:newinstance

Conversation

@snuyanzin

Copy link
Copy Markdown
Collaborator

No description provided.

@what-the-diff

what-the-diff Bot commented Apr 30, 2023

Copy link
Copy Markdown

PR Summary

  • Improved object instantiation
    Changed the object instantiation approach to use reflection, which allows compatibility with more classes, including those with private constructors.
  • Enhanced field accessibility and error handling
    Implemented a check to ensure fields are accessible before setting them via reflection and added exception handling to address potential issues during field access and invocation target exceptions.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #796 (9a2d203) into main (8edbed3) will decrease coverage by 0.06%.
The diff coverage is 80.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #796      +/-   ##
============================================
- Coverage     92.52%   92.47%   -0.06%     
+ Complexity     2653     2652       -1     
============================================
  Files           286      286              
  Lines          5274     5275       +1     
  Branches        553      553              
============================================
- Hits           4880     4878       -2     
- Misses          252      254       +2     
- Partials        142      143       +1     
Impacted Files Coverage Δ
...tafaker/transformations/JavaObjectTransformer.java 39.39% <80.00%> (+1.89%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin
snuyanzin merged commit e5b204b into datafaker-net:main Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants