Skip to content

Keep abc order in BaseProviders #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2023
Merged

Conversation

snuyanzin
Copy link
Collaborator

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Apr 30, 2023

PR Summary

  • Rearrangement of Methods in BaseProviders.java
    The order of methods in BaseProviders.java was changed for better organization.
  • Addition of dcComics() Method
    A new method dcComics() was added to BaseProviders.java, providing additional functionality.
  • Relocation of currency() and disease() Methods
    Two existing methods, currency() and disease(), were moved within the file for improved structure.

@codecov-commenter
Copy link

Codecov Report

Merging #798 (f52923e) into main (e5b204b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #798      +/-   ##
============================================
+ Coverage     92.54%   92.56%   +0.01%     
- Complexity     2654     2655       +1     
============================================
  Files           286      286              
  Lines          5275     5275              
  Branches        553      553              
============================================
+ Hits           4882     4883       +1     
  Misses          252      252              
+ Partials        141      140       -1     
Impacted Files Coverage Δ
...va/net/datafaker/providers/base/BaseProviders.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin snuyanzin merged commit d2c3889 into datafaker-net:main Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants