Skip to content

Configured Maven to create a MANIFEST file. Renamed Data Faker to Datafaker #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2023

Conversation

bodiam
Copy link
Contributor

@bodiam bodiam commented Apr 30, 2023

Example of MANIFEST.MF:

Manifest-Version: 1.0
Created-By: Maven JAR Plugin 3.3.0
Build-Jdk-Spec: 17
Specification-Title: Datafaker
Specification-Version: 2.0
Implementation-Title: Datafaker
Implementation-Version: 2.0.0-SNAPSHOT

Ref #794

…o Datafaker.

Example of MANIFEST.MF:

Manifest-Version: 1.0
Created-By: Maven JAR Plugin 3.3.0
Build-Jdk-Spec: 17
Specification-Title: Datafaker
Specification-Version: 2.0
Implementation-Title: Datafaker
Implementation-Version: 2.0.0-SNAPSHOT

Ref #794
@bodiam bodiam mentioned this pull request Apr 30, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #802 (1cc94db) into main (09e4d90) will increase coverage by 0.03%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #802      +/-   ##
============================================
+ Coverage     92.70%   92.74%   +0.03%     
- Complexity     2653     2654       +1     
============================================
  Files           286      286              
  Lines          5264     5264              
  Branches        553      553              
============================================
+ Hits           4880     4882       +2     
+ Misses          242      241       -1     
+ Partials        142      141       -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kingthorin kingthorin changed the title Configured Maven to create a MANIFEST file. Also renamed Data Faker t… Configured Maven to create a MANIFEST file. Renamed Data Faker to Datafaker Apr 30, 2023
Copy link
Collaborator

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bodiam bodiam merged commit 596561e into main Apr 30, 2023
@kingthorin kingthorin deleted the create_manifest_file branch April 30, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants