Various Dutch address and name improvements. #805
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #805 +/- ##
============================================
- Coverage 92.74% 92.68% -0.06%
+ Complexity 2654 2653 -1
============================================
Files 286 286
Lines 5264 5264
Branches 553 553
============================================
- Hits 4882 4879 -3
- Misses 241 243 +2
- Partials 141 142 +1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @RepeatedTest(100) | ||
| void dutchAddress() { | ||
| assertThat(NL_FAKER.address().stateAbbr()).matches("[A-Z]{2}"); | ||
| assertThat(NL_FAKER.address().fullAddress()).matches("[A-Z].+, [0-9]{4} [A-Z]{2}, [A-Z].+"); |
There was a problem hiding this comment.
should it check for only uppercase?
There was a problem hiding this comment.
it should check that the fullAddress starts with an uppercase, followed by anything: [A-Z].+ (mind the dot)
There was a problem hiding this comment.
(I've ran this test approx 1_000_000 times, but I thought that was a bit too much to commit)
Based on: https://onzetaal.nl/taalloket/afkortingen-van-provincienamen