You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updated method parameters
The method 'numberBetween(int min, int max)' now uses the 'final' keyword for its parameters, ensuring they remain constant throughout the method.
Optimized variable calculation
A new variable 'amplitude' of type long is declared and initialized to avoid duplicate calculations, improving efficiency.
Enhanced input validation
The input validation for the method now checks both minimum and maximum bounds to ensure a valid range, allowing it to work with positive and negative numbers.
Improved return value handling
The method returns an integer value casted from a double to better handle large ranges and potential overflow, without the need for throwing exceptions.
right now no difference
the only reason I made it it is kind of self-protection from possible reassigning values in methods in future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test to check
before the change it takes about 20x times longer to complete ...
the main idea is in case of overloading the limit use fallback to
longinstead of fallback toBigDecimal