From 59afe110278fef5f05b5d786be264389d88523e5 Mon Sep 17 00:00:00 2001 From: Leo Folsom Date: Tue, 28 Jun 2022 08:40:49 -0700 Subject: [PATCH 1/4] update readme with quotes and carrots (while in the forked repo this time) --- README.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 66fbf348..671c0cd9 100644 --- a/README.md +++ b/README.md @@ -112,13 +112,13 @@ $ data-diff \ | Database | Connection string | Status | |---------------|-----------------------------------------------------------------------------------------|--------| -| PostgreSQL | `postgresql://user:password@hostname:5432/database` | 💚 | -| MySQL | `mysql://user:password@hostname:5432/database` | 💚 | -| Snowflake | `snowflake://user:password@account/database/SCHEMA?warehouse=WAREHOUSE&role=role` | 💚 | -| Oracle | `oracle://username:password@hostname/database` | 💛 | -| BigQuery | `bigquery://project/dataset` | 💛 | -| Redshift | `redshift://username:password@hostname:5439/database` | 💛 | -| Presto | `presto://username:password@hostname:8080/database` | 💛 | +| PostgreSQL | `postgresql://:@:<5432>/` | 💚 | +| MySQL | `mysql://:@:<5432>/` | 💚 | +| Snowflake | `"snowflake://:@//?warehouse=&role="`| 💚 | +| Oracle | `oracle://:@/database` | 💛 | +| BigQuery | `bigquery:///` | 💛 | +| Redshift | `redshift://:@:<5439>/` | 💛 | +| Presto | `presto://:@:8080/` | 💛 | | ElasticSearch | | 📝 | | Databricks | | 📝 | | Planetscale | | 📝 | From f7fa628cc9ee8602a068d6502f220ae6175e988d Mon Sep 17 00:00:00 2001 From: Leo Folsom Date: Tue, 28 Jun 2022 08:43:41 -0700 Subject: [PATCH 2/4] saved the file --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 671c0cd9..475c5c93 100644 --- a/README.md +++ b/README.md @@ -118,7 +118,7 @@ $ data-diff \ | Oracle | `oracle://:@/database` | 💛 | | BigQuery | `bigquery:///` | 💛 | | Redshift | `redshift://:@:<5439>/` | 💛 | -| Presto | `presto://:@:8080/` | 💛 | +| Presto | `presto://:@:<8080>/` | 💛 | | ElasticSearch | | 📝 | | Databricks | | 📝 | | Planetscale | | 📝 | From 5fdd795c08ef65c325a164cb49a72f59b7356e66 Mon Sep 17 00:00:00 2001 From: Leo Folsom Date: Tue, 28 Jun 2022 08:54:10 -0700 Subject: [PATCH 3/4] add a heads up about case sensitivity --- README.md | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 475c5c93..b4760f2f 100644 --- a/README.md +++ b/README.md @@ -112,13 +112,13 @@ $ data-diff \ | Database | Connection string | Status | |---------------|-----------------------------------------------------------------------------------------|--------| -| PostgreSQL | `postgresql://:@:<5432>/` | 💚 | -| MySQL | `mysql://:@:<5432>/` | 💚 | +| PostgreSQL | `postgresql://:@:5432/` | 💚 | +| MySQL | `mysql://:@:5432/` | 💚 | | Snowflake | `"snowflake://:@//?warehouse=&role="`| 💚 | | Oracle | `oracle://:@/database` | 💛 | | BigQuery | `bigquery:///` | 💛 | -| Redshift | `redshift://:@:<5439>/` | 💛 | -| Presto | `presto://:@:<8080>/` | 💛 | +| Redshift | `redshift://:@:5439/` | 💛 | +| Presto | `presto://:@:8080/` | 💛 | | ElasticSearch | | 📝 | | Databricks | | 📝 | | Planetscale | | 📝 | @@ -171,7 +171,10 @@ Users can also install several drivers at once: Usage: `data-diff DB1_URI TABLE1_NAME DB2_URI TABLE2_NAME [OPTIONS]` See the [example command](#example-command-and-output) and the [sample -connection strings](#supported-databases). +connection strings](#supported-databases). + +Note that for some databases, the arguments that you enter in the command line +may be case-sensitive. This is the case for the Snowflake schema and table names. Options: From 866ac49099fa97024fb1a50c22a36cdedde2900e Mon Sep 17 00:00:00 2001 From: Leo Folsom Date: Tue, 28 Jun 2022 09:02:29 -0700 Subject: [PATCH 4/4] line up database table columns --- README.md | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/README.md b/README.md index b4760f2f..8ddca7d8 100644 --- a/README.md +++ b/README.md @@ -110,22 +110,22 @@ $ data-diff \ ## Supported Databases -| Database | Connection string | Status | -|---------------|-----------------------------------------------------------------------------------------|--------| -| PostgreSQL | `postgresql://:@:5432/` | 💚 | -| MySQL | `mysql://:@:5432/` | 💚 | +| Database | Connection string | Status | +|---------------|--------------------------------------------------------------------------------------------------|--------| +| PostgreSQL | `postgresql://:@:5432/` | 💚 | +| MySQL | `mysql://:@:5432/` | 💚 | | Snowflake | `"snowflake://:@//?warehouse=&role="`| 💚 | -| Oracle | `oracle://:@/database` | 💛 | -| BigQuery | `bigquery:///` | 💛 | -| Redshift | `redshift://:@:5439/` | 💛 | -| Presto | `presto://:@:8080/` | 💛 | -| ElasticSearch | | 📝 | -| Databricks | | 📝 | -| Planetscale | | 📝 | -| Clickhouse | | 📝 | -| Pinot | | 📝 | -| Druid | | 📝 | -| Kafka | | 📝 | +| Oracle | `oracle://:@/database` | 💛 | +| BigQuery | `bigquery:///` | 💛 | +| Redshift | `redshift://:@:5439/` | 💛 | +| Presto | `presto://:@:8080/` | 💛 | +| ElasticSearch | | 📝 | +| Databricks | | 📝 | +| Planetscale | | 📝 | +| Clickhouse | | 📝 | +| Pinot | | 📝 | +| Druid | | 📝 | +| Kafka | | 📝 | * 💚: Implemented and thoroughly tested. * 💛: Implemented, but not thoroughly tested yet.