New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin_config_dir and plugin_dir should be config options, not meta #104

Closed
derks opened this Issue Apr 20, 2012 · 1 comment

Comments

Projects
None yet
1 participant
@derks
Member

derks commented Apr 20, 2012

Anything path related should be config file options, not hard coded meta.

@ghost ghost assigned derks Apr 20, 2012

derks pushed a commit that referenced this issue Apr 27, 2012

@derks

This comment has been minimized.

Show comment
Hide comment
@derks

derks Apr 27, 2012

Member

This was resolved by adding a 'meta_override' and 'core_meta_override' option to CementApp.Meta. By default, the core_meta_override includes:

['debug', 'plugin_config_dir', 'plugin_dir']

So now those options can/will be overridden by config settings of the same name under the [base] sections.

Member

derks commented Apr 27, 2012

This was resolved by adding a 'meta_override' and 'core_meta_override' option to CementApp.Meta. By default, the core_meta_override includes:

['debug', 'plugin_config_dir', 'plugin_dir']

So now those options can/will be overridden by config settings of the same name under the [base] sections.

@derks derks closed this Apr 27, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment