New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CementApp._resolve_handler() as handler.resolve() #160

Closed
derks opened this Issue Aug 3, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@derks
Member

derks commented Aug 3, 2012

No description provided.

@ghost ghost assigned derks Aug 3, 2012

@chrisguiney

This comment has been minimized.

Show comment
Hide comment
@chrisguiney

chrisguiney Mar 22, 2013

Has any work been done on this? It's something I'd be very interested in (and willing to help out on).

from what I can tell, the only usages are in foundation.py, setting up the core handlers.

I've only been using cement for a few days, so forgive me if my assessment is inaccurate, but would it not just be moving and updating resolve_handler to the handler class, and updating the calls in foundation.py?

chrisguiney commented Mar 22, 2013

Has any work been done on this? It's something I'd be very interested in (and willing to help out on).

from what I can tell, the only usages are in foundation.py, setting up the core handlers.

I've only been using cement for a few days, so forgive me if my assessment is inaccurate, but would it not just be moving and updating resolve_handler to the handler class, and updating the calls in foundation.py?

derks added a commit that referenced this issue Mar 27, 2013

@derks

This comment has been minimized.

Show comment
Hide comment
@derks

derks Mar 27, 2013

Member

I've committed this change to the master branch. Can you please test out handler.resolve() and verify that it does what you are wanting/needing it to do?

Thanks!

Member

derks commented Mar 27, 2013

I've committed this change to the master branch. Can you please test out handler.resolve() and verify that it does what you are wanting/needing it to do?

Thanks!

@derks derks closed this Jun 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment