Standardize handler naming conventions #227

Closed
derks opened this Issue Jan 23, 2014 · 1 comment

Comments

Projects
None yet
1 participant
@derks
Member

derks commented Jan 23, 2014

Need to standardize more on naming conventions. For example the "LoggingLogHandler" implements ILog ('log') but the name of the handler config section is 'log', versus MemcachedCacheHandler which implements ICache ('cache') but its config section name is "cache.memcached".

Should standardize on "<interface_label>.<handler_label>" for all config sections.

[myapp]
log_handler = logging
cache_handler = memcached
mail_handler = sendgrid

[log.logging]
file = /path/to/my/log/file
level = warn

[log.syslog]
address = logs.papertrailapp.com
port = 12345

[cache.memcached]
servers = cache1.example.com:11111, cache2.example.com:11111
expire = 300

[cache.memory]
expire = 300

[mail.smtp]
username = myuser
password = mypassword
address = smtp.example.com
port = 25
ssl = 1

[mail.sendgrid]
username = myuser
password = mypassword
api_type = web

@ghost ghost assigned derks Jan 23, 2014

@derks derks assigned derks and unassigned derks Aug 21, 2014

@derks

This comment has been minimized.

Show comment
Hide comment
@derks

derks Aug 28, 2014

Member

Just a note, the only handler this affects currently is log.logging, everything else is using the standard convention.

Member

derks commented Aug 28, 2014

Just a note, the only handler this affects currently is log.logging, everything else is using the standard convention.

derks added a commit that referenced this issue Aug 29, 2014

@derks derks closed this Aug 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment