Use of CementApp.Meta.base_controller is unecessary #308

derks opened this Issue May 6, 2015 · 0 comments


None yet
1 participant

derks commented May 6, 2015

I believe (have to dig through code) that the current implementation requires that the base controller have a label of base. Therefore, it is redundant to make developers set CementApp.Meta.base_controller. We should just default it to base and if it doesn't exist (isn't registered) then just log it to debug but not have a hard requirement on it.

@derks derks self-assigned this May 6, 2015

@derks derks added this to the 2.5.2 Development milestone May 6, 2015

derks added a commit that referenced this issue May 12, 2015

@derks derks closed this May 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment