New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Plugin Directories #350

Closed
akhilman opened this Issue Apr 26, 2016 · 7 comments

Comments

Projects
None yet
2 participants
@akhilman
Contributor

akhilman commented Apr 26, 2016

For now cement checks .py file existence and do not allows to load plugins from directories like:

pluginname/
    __init__.py -- contains load(app)
    controller.py -- contains controller
    morecode.py -- contains more random code

plugin directories will be useful for large plugin modules with submodules.

I can try to hack plugin handler to allow load plugins from directories.

@derks

This comment has been minimized.

Show comment
Hide comment
@derks

derks Apr 26, 2016

Member

This is a great idea, and should not be hard to implement at all (just putting load() in init.py or similar like you suggested).

Member

derks commented Apr 26, 2016

This is a great idea, and should not be hard to implement at all (just putting load() in init.py or similar like you suggested).

@derks derks added this to the 2.10.0 Stable milestone Apr 26, 2016

@akhilman

This comment has been minimized.

Show comment
Hide comment
@akhilman

akhilman Apr 26, 2016

Contributor

Ok. I'll do this and will make pull request.

On Tue, 2016-04-26 at 06:49 -0700, BJ Dierkes wrote:

This is a great idea, and should not be hard to implement at all
(just putting load() in init.py or similar like you suggested).


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#350 (comment)
277

Contributor

akhilman commented Apr 26, 2016

Ok. I'll do this and will make pull request.

On Tue, 2016-04-26 at 06:49 -0700, BJ Dierkes wrote:

This is a great idea, and should not be hard to implement at all
(just putting load() in init.py or similar like you suggested).


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#350 (comment)
277

@akhilman

This comment has been minimized.

Show comment
Hide comment
@akhilman

akhilman Apr 28, 2016

Contributor

Also I would like to have ability to load precomiled (Cython) plugins.

Contributor

akhilman commented Apr 28, 2016

Also I would like to have ability to load precomiled (Cython) plugins.

@derks derks removed the portland label Jul 7, 2016

@derks derks changed the title from plugins as python directory modules to Support for Plugin Directories Jul 7, 2016

@derks

This comment has been minimized.

Show comment
Hide comment
@derks

derks Jul 7, 2016

Member

@akhilman can you create a new issue regarding the precompiled Cython plugins? I'd like to handle that separately from this feature request. Would like some more context around what you'd like to accomplish as well. Thanks.

Member

derks commented Jul 7, 2016

@akhilman can you create a new issue regarding the precompiled Cython plugins? I'd like to handle that separately from this feature request. Would like some more context around what you'd like to accomplish as well. Thanks.

@akhilman

This comment has been minimized.

Show comment
Hide comment
@akhilman

akhilman Jul 7, 2016

Contributor

@derks ok, I'll do as soon as I start to rewrite my application using cython.

Contributor

akhilman commented Jul 7, 2016

@derks ok, I'll do as soon as I start to rewrite my application using cython.

derks added a commit that referenced this issue Jul 7, 2016

@derks

This comment has been minimized.

Show comment
Hide comment
@derks

derks Jul 7, 2016

Member

@akhilman this has been added to master, and will be included in stable/2.10.0. Would you mind giving it a try and let me know how it works out for you?

See: http://cement.readthedocs.io/en/latest/dev/plugins/#single-file-plugins-vs-plugin-directories

Member

derks commented Jul 7, 2016

@akhilman this has been added to master, and will be included in stable/2.10.0. Would you mind giving it a try and let me know how it works out for you?

See: http://cement.readthedocs.io/en/latest/dev/plugins/#single-file-plugins-vs-plugin-directories

@akhilman

This comment has been minimized.

Show comment
Hide comment
@akhilman

akhilman Jul 7, 2016

Contributor

Directory plug-ins works well. Thank you.

Contributor

akhilman commented Jul 7, 2016

Directory plug-ins works well. Thank you.

@akhilman akhilman closed this Jul 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment