Support for cythonized Plugins #380

Closed
akhilman opened this Issue Jul 7, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@akhilman
Contributor

akhilman commented Jul 7, 2016

Adding support for cythonized plug-ins seems to be simple as add one more search path to:

        dll_suffix = do_magick()
        paths = [
            os.path.join(plugin_dir, "%s.py" % plugin_name),
            os.path.join(plugin_dir, plugin_name, "__init__.py"),
            os.path.join(plugin_dir, "%s.%s" % plugin_name, dll_suffix),
        ]

in ext_plugin.py

But I don't know how to determine right dll suffix. For linux it seems to be .so, but for Windows and MacOS things seems not so simple.

akhilman added a commit to akhilman/cement that referenced this issue Jul 7, 2016

Support for ctyhonized Plugins
fixes #380

Support for all kind of pre-compiled plugins. Should work with
all platforms.

akhilman added a commit to akhilman/cement that referenced this issue Jul 7, 2016

Support for cythonized Plugins
fixes #380

Support for all kind of pre-compiled plugins. Should work with
all platforms.

akhilman added a commit to akhilman/cement that referenced this issue Jul 8, 2016

Support for cythonized Plugins
fixes #380

Support for all kind of pre-compiled plugins. Should work with
all platforms.

akhilman added a commit to akhilman/cement that referenced this issue Jul 8, 2016

Support for cythonized Plugins
fixes #380

Support for all kind of pre-compiled plugins. Should work with
all platforms.

@derks derks added 1 - Ready and removed 1 - Ready labels Jul 12, 2016

derks added a commit that referenced this issue Jul 12, 2016

@derks

This comment has been minimized.

Show comment
Hide comment
@derks

derks Jul 12, 2016

Member

@akhilman can you try out latest master and verify that this all works for you? Thanks!

Member

derks commented Jul 12, 2016

@akhilman can you try out latest master and verify that this all works for you? Thanks!

@derks derks added this to the 2.10.0 Stable milestone Jul 12, 2016

@derks derks added the feature label Jul 12, 2016

@derks derks self-assigned this Jul 12, 2016

@derks derks added 3 - Review and removed 2 - Working <= 5 labels Jul 12, 2016

@akhilman

This comment has been minimized.

Show comment
Hide comment
@akhilman

akhilman Jul 13, 2016

Contributor

Works well for me. Thank you!

Contributor

akhilman commented Jul 13, 2016

Works well for me. Thank you!

@akhilman akhilman closed this Jul 13, 2016

@derks derks added 4 - Done and removed 3 - Review labels Jul 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment