New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_validator checks if warn method is available #397

Closed
barta0 opened this Issue Jul 23, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@barta0

barta0 commented Jul 23, 2016

The log_validator checks if warn method is available, but ILog interface has no method with this name, that should be implemented.

@derks

This comment has been minimized.

Member

derks commented Jul 25, 2016

@barta0 thanks for that.. this is due to a recent change in 2.10. Previously the interface defined that a handler implement warn()... it is now, warning(), but I forgot to remove that from the validator. For the interrim you can just make warn() call self.warning() until next release when this is fixed.

@derks derks self-assigned this Nov 23, 2016

@derks derks added this to the 2.12.0 Stable milestone Nov 23, 2016

@derks derks added 2 - Working <= 5 and removed 1 - Ready labels Nov 23, 2016

derks added a commit that referenced this issue Nov 23, 2016

Resolves Issue #397
Removes deprecated `warn` from ILog validator, in-favor of `warning`.

derks added a commit that referenced this issue Nov 23, 2016

Resolves Issue #397
Removes deprecated `warn` from ILog validator, in-favor of `warning`.

@derks derks closed this Nov 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment