Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]Support create stage statement #3253

Merged
merged 7 commits into from Dec 6, 2021

Conversation

GrapeBaBa
Copy link
Contributor

Signed-off-by: grapebaba 281165273@qq.com

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

Support create stage statement

Changelog

  • New Feature

Related Issues

Fixes #2900

Test Plan

Unit Tests

Stateless Tests

Signed-off-by: grapebaba <281165273@qq.com>
@databend-bot databend-bot added the pr-feature this PR introduces a new feature to the codebase label Dec 5, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Dec 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/EahRXTJJdWEk6H1kcQbvTeNBoXVL
✅ Preview: Canceled

[Deployment for 1840c52 canceled]

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2021

Codecov Report

Merging #3253 (33b14af) into main (482151c) will decrease coverage by 0%.
The diff coverage is 83%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3253     +/-   ##
=======================================
- Coverage     66%     65%     -1%     
=======================================
  Files        687     702     +15     
  Lines      36536   37967   +1431     
=======================================
+ Hits       24211   24900    +689     
- Misses     12325   13067    +742     
Impacted Files Coverage Δ
common/planners/src/plan_node.rs 41% <0%> (-1%) ⬇️
common/planners/src/plan_rewriter.rs 46% <0%> (-1%) ⬇️
query/src/interpreters/interpreter_factory.rs 32% <0%> (-2%) ⬇️
query/src/sql/sql_parser_test.rs 78% <73%> (-1%) ⬇️
common/meta/types/src/user_stage.rs 81% <83%> (+31%) ⬆️
common/planners/src/plan_user_stage_create.rs 85% <85%> (ø)
query/src/interpreters/interpreter_stage_create.rs 87% <87%> (ø)
query/src/sql/sql_parser.rs 85% <88%> (+<1%) ⬆️
query/src/users/user_stage_test.rs 94% <88%> (-4%) ⬇️
.../src/interpreters/interpreter_stage_create_test.rs 92% <92%> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 482151c...33b14af. Read the comment docs.

Signed-off-by: grapebaba <281165273@qq.com>
Signed-off-by: grapebaba <281165273@qq.com>
Signed-off-by: grapebaba <281165273@qq.com>
Signed-off-by: grapebaba <281165273@qq.com>
@GrapeBaBa GrapeBaBa marked this pull request as ready for review December 6, 2021 09:15
@GrapeBaBa
Copy link
Contributor Author

/review @sundy-li

@databend-bot
Copy link
Member

Take the reviewer to sundy-li

Signed-off-by: grapebaba <281165273@qq.com>
@databend-bot
Copy link
Member

Wait for another reviewer approval

Signed-off-by: grapebaba <281165273@qq.com>
@BohuTANG
Copy link
Member

BohuTANG commented Dec 6, 2021

/lgtm
👍

@databend-bot
Copy link
Member

CI Passed
Reviewers Approved
Let's Merge
Thank you for the PR @GrapeBaBa

@BohuTANG BohuTANG merged commit 160b73a into datafuselabs:main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support create/describe stage
5 participants