refactor join cluster process #4219
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/databend/databend/EHMxJnmtTaQDE374iZYXrgapBeDa |
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
| @@ -412,6 +412,47 @@ impl MetaNode { | |||
| Ok(mn) | |||
| } | |||
|
|
|||
| pub async fn join_cluster(&self, conf: &RaftConfig) -> MetaResult<()> { | |||
| if conf.join.is_empty() { | |||
| return Ok(()); | |||
There was a problem hiding this comment.
Should we log a warning message when this config is empty?
There was a problem hiding this comment.
I think the elaborated name of this method should be try_to_join_cluster_if_cli_arg_join_is_specified().
conf.join being empty means the user did not pass --join arguments to metasrv. It's totally OK.
| let addrs = &conf.join; | ||
| // Join cluster use advertise host instead of listen host | ||
| let raft_api_advertise_host_endpoint = conf.raft_api_advertise_host_endpoint(); | ||
| #[allow(clippy::never_loop)] |
There was a problem hiding this comment.
It's an unfinished code snippet... There should be a retry loop... :((
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Changelog
Related Issues
Fixes 4218
Test Plan
Unit Tests
Stateless Tests