Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add metrics in metasrv #5208

Merged
merged 15 commits into from May 13, 2022

Conversation

lichuang
Copy link
Collaborator

@lichuang lichuang commented May 7, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Feature: add metrics framework in metasrv.
More metrics will be added after this pr.

Changelog

  • New Feature

Related Issues

part of metrics API providing requests/sec, active watchers, outstanding(uncommitted) raft logs, number of raft logs, state machine size etc. · Issue #4938 · datafuselabs/databend

@lichuang lichuang requested a review from BohuTANG as a code owner May 7, 2022 06:46
@vercel
Copy link

vercel bot commented May 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview May 13, 2022 at 5:51AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented May 7, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label May 7, 2022
@lichuang lichuang added the A-meta Area: databend meta serive label May 7, 2022
Comment on lines +30 to +34
impl Default for MetaMetrics {
fn default() -> Self {
Self::new()
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be derived.

But it's not a big deal and should not be a blocker for this PR.

Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@BohuTANG
Copy link
Member

BohuTANG commented May 7, 2022

@mergify update

@mergify
Copy link
Contributor

mergify bot commented May 7, 2022

update

✅ Branch has been successfully updated

@BohuTANG
Copy link
Member

BohuTANG commented May 8, 2022

This patch broke the CI:

---- api::http::cluster_state_test::test_cluster_state stdout ----
thread 'api::http::cluster_state_test::test_cluster_state' panicked at 'metametrics is not initialized', metasrv/src/metrics/meta_metrics.rs:42:24
stack backtrace:
   0:     0x5590aa0c088d - std::backtrace_rs::backtrace::libunwind::trace::h701a19af54e96518
                               at /rustc/76d770ac21d9521db6a92a48c7b3d5b2cc535941/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93:5

https://github.com/datafuselabs/databend/runs/6334802517?check_suite_focus=true#step:3:954

@BohuTANG
Copy link
Member

BohuTANG commented May 9, 2022

This patch broke the CI:

---- api::http::cluster_state_test::test_cluster_state stdout ----
thread 'api::http::cluster_state_test::test_cluster_state' panicked at 'metametrics is not initialized', metasrv/src/metrics/meta_metrics.rs:42:24
stack backtrace:
   0:     0x5590aa0c088d - std::backtrace_rs::backtrace::libunwind::trace::h701a19af54e96518
                               at /rustc/76d770ac21d9521db6a92a48c7b3d5b2cc535941/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93:5

https://github.com/datafuselabs/databend/runs/6334802517?check_suite_focus=true#step:3:954

cc @lichuang

@lichuang
Copy link
Collaborator Author

@BohuTANG
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented May 13, 2022

update

☑️ Nothing to do

  • -closed [:pushpin: update requirement]
  • #commits-behind>0 [:pushpin: update requirement]

@BohuTANG BohuTANG merged commit f8532a8 into datafuselabs:main May 13, 2022
@lichuang lichuang deleted the metasrv_add_metrics branch May 14, 2022 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: databend meta serive need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants