fix(query): fix input format CSV #6524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
zhang2014
approved these changes
Jul 7, 2022
|
flaky tests, pass on my mac |
|
results lost. cc @zhang2014 |
|
test_sqllogic_standalone_linux failure is not related to this pr, let's merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
both python and rust CSV lib support 4 QuoteStyple
https://docs.rs/csv/latest/csv/enum.QuoteStyle.html
except the last one the 4, CSV mainly uses quote (instead of escape) to deal with field/record delimiters in strings, and uses quote to escape it self by default.
and clickhouse input format only supports this style.
so we should support this style first.
Summary about this PR
Fixes #issue