Skip to content

Conversation

@Mottl
Copy link
Contributor

@Mottl Mottl commented Apr 25, 2025

This PR updates crate versions and fixes #48

Current arrow already uses 0.4.40 of chrono:
https://github.com/apache/arrow-rs/blob/5f0aed6b71cb9e6f38a3735b76ee89f4a0aea393/Cargo.toml#L96

#43

@progval
Copy link
Collaborator

progval commented Apr 25, 2025

Looks good, but could we have a v0.6.1 release (ie. 0.6.0 + only #47) before merging this? This way it gives a usable orc-rust version for people who need arrow < 55 for whatever reason.

@Mottl
Copy link
Contributor Author

Mottl commented Apr 26, 2025

Make sense. Can we then just remove the unsupported 55.0.0 from
arrow = { version = ">= 53.1.0, < 55.0.0", features = ["prettyprint", "chrono-tz", "ipc_compression"] },
so it will work with any version of arrow >= 53.1?

@progval
Copy link
Collaborator

progval commented Apr 26, 2025

You can try, but it's probably not going to work because 55.0.0 has a conflicting requirement on chrono

@Mottl
Copy link
Contributor Author

Mottl commented Apr 26, 2025

It will, because arrow 55.0.0 uses chrono 0.4.40. Removing upper version boundaries will allow to build on both older and newer versions of arrow & chrono.

cargo check
...
Checking chrono v0.4.40
Checking arrow v55.0.0
...
Checking orc-rust v0.6.0
Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.28s

@Mottl
Copy link
Contributor Author

Mottl commented May 5, 2025

@progval?

@bitcapybara
Copy link

May I ask if there has been any progress on this PR? I encountered the same issue in my project.

@progval progval mentioned this pull request Aug 14, 2025
@WenyXu WenyXu merged commit 8e79e56 into datafusion-contrib:main Aug 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to compile because of the stale chrono and arrow versions

4 participants