Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign the login page #4684

Merged
merged 3 commits into from Apr 20, 2022
Merged

Redesign the login page #4684

merged 3 commits into from Apr 20, 2022

Conversation

Ankit-Keshari-Vituity
Copy link
Contributor

worked on a new look of the Login page.

resign_login_page

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Apr 18, 2022 •
edited

Unit Test Results (build & test)

  96 files  ±0    96 suites  ±0   21m 16s ⏱️ - 3m 19s
689 tests ±0  630 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit 7fd45a4. ± Comparison against base commit 15474cd.

♻️ This comment has been updated with latest results.

jjoyce0510
jjoyce0510 approved these changes Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thank you!

@jjoyce0510 jjoyce0510 merged commit f659cc8 into datahub-project:master Apr 20, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@Ankit-Keshari-Vituity @maggiehays
Redesign the login page (datahub-project#4684)
9222078
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees

@jjoyce0510 jjoyce0510

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ankit-Keshari-Vituity @jjoyce0510