Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingestion): looker - Handling gracefully invalid json in query dynamic field #5083

Merged

Conversation

treff7es
Copy link
Contributor

@treff7es treff7es commented Jun 3, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Unit Test Results (build & test)

334 tests  ±0   334 ✔️ ±0   3m 2s ⏱️ ±0s
  78 suites ±0       0 💤 ±0 
  78 files   ±0       0 ±0 

Results for commit 4165c14. ± Comparison against base commit 4da3d13.

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Unit Test Results (metadata ingestion)

       5 files         5 suites   1h 28m 41s ⏱️
   551 tests    547 ✔️     3 💤 1
2 470 runs  2 364 ✔️ 105 💤 1

For more details on these failures, see this check.

Results for commit 4165c14.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test failures seem unrelated.

@shirshanka shirshanka merged commit aeffd26 into datahub-project:master Jun 3, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@treff7es treff7es deleted the looker_graceful_json_error branch February 8, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants