Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(roles): add ability to invite users into a role #6015

Merged

Conversation

aditya-radhakrishnan
Copy link
Contributor

@aditya-radhakrishnan aditya-radhakrishnan commented Sep 21, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Sep 21, 2022
@github-actions
Copy link

github-actions bot commented Sep 21, 2022

Unit Test Results (build & test)

584 tests  +16   580 ✔️ +16   13m 3s ⏱️ -13s
143 suites +  3       4 💤 ±  0 
143 files   +  3       0 ±  0 

Results for commit 0849393. ± Comparison against base commit f57f398.

This pull request removes 9 and adds 25 tests. Note that renamed tests count towards both.
com.datahub.authentication.user.NativeUserServiceTest ‑ testConstructor
com.datahub.authentication.user.NativeUserServiceTest ‑ testCreateNativeUserInviteTokenDoesNotExist
com.datahub.authentication.user.NativeUserServiceTest ‑ testGenerateNativeUserInviteTokenPasses
com.datahub.authentication.user.NativeUserServiceTest ‑ testGetNativeUserInviteTokenInviteTokenDoesNotExistPasses
com.datahub.authentication.user.NativeUserServiceTest ‑ testGetNativeUserInviteTokenPasses
com.linkedin.datahub.graphql.resolvers.user.CreateNativeUserInviteTokenResolverTest ‑ testFailsCannotManageUserCredentials
com.linkedin.datahub.graphql.resolvers.user.CreateNativeUserInviteTokenResolverTest ‑ testPasses
com.linkedin.datahub.graphql.resolvers.user.GetNativeUserInviteTokenResolverTest ‑ testFailsCannotManageUserCredentials
com.linkedin.datahub.graphql.resolvers.user.GetNativeUserInviteTokenResolverTest ‑ testPasses
com.datahub.authentication.invite.InviteTokenServiceTest ‑ getInviteToken
com.datahub.authentication.invite.InviteTokenServiceTest ‑ getInviteTokenEmptySearchResult
com.datahub.authentication.invite.InviteTokenServiceTest ‑ getInviteTokenNoInviteTokenAspect
com.datahub.authentication.invite.InviteTokenServiceTest ‑ getInviteTokenNullEntity
com.datahub.authentication.invite.InviteTokenServiceTest ‑ getInviteTokenRegenerate
com.datahub.authentication.invite.InviteTokenServiceTest ‑ getInviteTokenRoleUrnDoesNotExist
com.datahub.authentication.invite.InviteTokenServiceTest ‑ testGetInviteTokenRole
com.datahub.authentication.invite.InviteTokenServiceTest ‑ testGetInviteTokenRoleEmptyAspectMap
com.datahub.authentication.invite.InviteTokenServiceTest ‑ testGetInviteTokenRoleNoRole
com.datahub.authentication.invite.InviteTokenServiceTest ‑ testGetInviteTokenRoleNullEntity
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 21, 2022

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 1m 7s ⏱️
   717 tests    714 ✔️ 3 💤 0
1 436 runs  1 430 ✔️ 6 💤 0

Results for commit 0849393.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed offline - Looks great to me Aditya. Nice work on this awesome feature.

@jjoyce0510 jjoyce0510 merged commit 325b959 into datahub-project:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants