Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(recommendations): Bump default max recommendations count for Platforms #6113

Merged

Conversation

jjoyce0510
Copy link
Collaborator

Summary

In this PR, we increase the max recommendations count for Platforms from 20 to 40.

Status

One line change, ready for review.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 4, 2022
@xiphl
Copy link
Contributor

xiphl commented Oct 4, 2022

how about changing the tag/term count in search filter as well? :)

Copy link
Collaborator

@pedro93 pedro93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let’s wait for green CI

Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Unit Test Results (build & test)

584 tests  ±0   580 ✔️ ±0   13m 1s ⏱️ +5s
143 suites ±0       4 💤 ±0 
143 files   ±0       0 ±0 

Results for commit 08d012e. ± Comparison against base commit bea5a07.

@anshbansal anshbansal merged commit e2c5d2a into datahub-project:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants