Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): make kafka emit callback optional #6525

Merged
merged 1 commit into from Nov 22, 2022
Merged

fix(ingest): make kafka emit callback optional #6525

merged 1 commit into from Nov 22, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 22, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 22, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   55m 37s ⏱️ - 1m 31s
   761 tests ±0     758 ✔️ ±0  3 💤 ±0  0 ❌ ±0 
1 524 runs  ±0  1 517 ✔️ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit 474cb6c. ± Comparison against base commit a1b3929.

@github-actions
Copy link

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 41s ⏱️ -2s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 474cb6c. ± Comparison against base commit a1b3929.

jjoyce0510
jjoyce0510 approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Thanks for cleaning up

@hsheth2 hsheth2 merged commit 2b9b123 into datahub-project:master Nov 22, 2022
@hsheth2 hsheth2 deleted the kafka-callback-optional branch November 22, 2022 21:57
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@hsheth2 @cccs-Dustin
fix(ingest): make kafka emit callback optional (datahub-project#6525)
43cff9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hsheth2 @jjoyce0510