Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): reporting revamp, part 1 #7031

Merged
merged 12 commits into from Jan 18, 2023
Merged

feat(ingest): reporting revamp, part 1 #7031

merged 12 commits into from Jan 18, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jan 13, 2023 •
edited

  • adds a specialized EntityFilterReport type
  • uses the EntityFilterReport in the unity catalog source
  • makes all ingestion sources print a summary with sample urns by entity type
  • makes all ingestion sources print a summary of aspect counts, broken down by entity type

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 13, 2023
@hsheth2 hsheth2 changed the title feat(ingest): reporting revamp feat(ingest): reporting revamp, part 1 Jan 18, 2023
@hsheth2 hsheth2 marked this pull request as ready for review January 18, 2023 17:37
treff7es
treff7es approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hsheth2 hsheth2 merged commit e23eb71 into datahub-project:master Jan 18, 2023
@hsheth2 hsheth2 deleted the reporting branch January 18, 2023 21:34
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
@hsheth2
feat(ingest): reporting revamp, part 1 (datahub-project#7031)
8cebd5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hsheth2 @treff7es